Skip to content

[Merged by Bors] - feat(Algebra/Order/BigOperators): prove lemmas for List.prod and Multiset.prod on CommMonoidWithZero - #16573

Closed
Command-Master wants to merge 7 commits into
masterfrom
CM_multiset
Closed

[Merged by Bors] - feat(Algebra/Order/BigOperators): prove lemmas for List.prod and Multiset.prod on CommMonoidWithZero#16573
Command-Master wants to merge 7 commits into
masterfrom
CM_multiset

Conversation

@Command-Master

Copy link
Copy Markdown
Collaborator

Also relax typeclass assumptions on prod_nonneg.


Open in Gitpod

@Command-Master Command-Master added t-algebra Algebra (groups, rings, fields, etc) t-order Order theory labels Sep 7, 2024
@github-actions

github-actions Bot commented Sep 7, 2024

Copy link
Copy Markdown

PR summary 1b8f9bd0a8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Order.BigOperators.GroupWithZero.List 383
Mathlib.Algebra.Order.BigOperators.GroupWithZero.Multiset 402

Declarations diff

+ CanonicallyOrderedCommSemiring.list_prod_pos
+ CanonicallyOrderedCommSemiring.multiset_prod_pos
++ one_le_prod
++ prod_map_le_prod_map₀
++ prod_map_lt_prod_map
- _root_.CanonicallyOrderedCommSemiring.list_prod_pos
- _root_.CanonicallyOrderedCommSemiring.multiset_prod_pos
-++ prod_nonneg
-++ prod_pos

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those lemmas now look misplaced. Can you move them to a new file Algebra.Order.BigOperators.GroupWithZero?

@Command-Master

Copy link
Copy Markdown
Collaborator Author

Those lemmas now look misplaced. Can you move them to a new file Algebra.Order.BigOperators.GroupWithZero?

The corresponding lemmas for Finset are also in Ring, for instance Finset.prod_nonneg

@YaelDillies

Copy link
Copy Markdown
Contributor

That is an oversight. They should be moved too (although no need for you to do it in the current PR)

@Command-Master Command-Master changed the title feat(Algebra/Order/BigOperators/Ring/Multiset): prove lemmas for Multiset.prod on CommMonoidWithZero feat(Algebra/Order/BigOperators/Ring/Multiset): prove lemmas for List.prod and Multiset.prod on CommMonoidWithZero Sep 8, 2024
@Command-Master Command-Master changed the title feat(Algebra/Order/BigOperators/Ring/Multiset): prove lemmas for List.prod and Multiset.prod on CommMonoidWithZero feat(Algebra/Order/BigOperators): prove lemmas for List.prod and Multiset.prod on CommMonoidWithZero Sep 8, 2024
Comment thread Mathlib/Algebra/Order/BigOperators/GroupWithZero/Multiset.lean Outdated
Comment thread Mathlib/Algebra/Order/BigOperators/GroupWithZero/List.lean Outdated
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 8, 2024
@Command-Master Command-Master removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 8, 2024
@YaelDillies

Copy link
Copy Markdown
Contributor

Thanks :)

maintainer merge

@github-actions

github-actions Bot commented Sep 8, 2024

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 8, 2024
@kim-em

kim-em commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

bors merge

@github-actions github-actions Bot added the ready-to-merge This PR has been sent to bors. label Sep 9, 2024
mathlib-bors Bot pushed a commit that referenced this pull request Sep 9, 2024
…ultiset.prod` on `CommMonoidWithZero` (#16573)

Also relax typeclass assumptions on `prod_nonneg`.



Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
@mathlib-bors

mathlib-bors Bot commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Algebra/Order/BigOperators): prove lemmas for List.prod and Multiset.prod on CommMonoidWithZero [Merged by Bors] - feat(Algebra/Order/BigOperators): prove lemmas for List.prod and Multiset.prod on CommMonoidWithZero Sep 9, 2024
@mathlib-bors mathlib-bors Bot closed this Sep 9, 2024
@mathlib-bors
mathlib-bors Bot deleted the CM_multiset branch September 9, 2024 02:03
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
…ultiset.prod` on `CommMonoidWithZero` (#16573)

Also relax typeclass assumptions on `prod_nonneg`.



Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
…ultiset.prod` on `CommMonoidWithZero` (#16573)

Also relax typeclass assumptions on `prod_nonneg`.



Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
…ultiset.prod` on `CommMonoidWithZero` (#16573)

Also relax typeclass assumptions on `prod_nonneg`.



Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants