[Merged by Bors] - chore: Delete Data.Nat.Units, Data.Int.Units - #12835
Closed
YaelDillies wants to merge 4 commits into
Closed
[Merged by Bors] - chore: Delete Data.Nat.Units, Data.Int.Units#12835YaelDillies wants to merge 4 commits into
Data.Nat.Units, Data.Int.Units#12835YaelDillies wants to merge 4 commits into
Conversation
The lemmas can easily move to `Algebra.Group.Nat` and `Algebra.Group.Int`, `Algebra.Ring.Int` respectively.
YaelDillies
added
awaiting-review
awaiting-CI
1 task
github-actions
Bot
removed
the
awaiting-CI
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
Contributor
There was a problem hiding this comment.
lgtm modulo the location of units_eq_one_or/units_ne_iff_eq_neg
Ruben-VandeVelde
added
awaiting-author
YaelDillies
added
awaiting-review
and removed
awaiting-author
Ruben-VandeVelde
approved these changes
May 15, 2024
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
Contributor
There was a problem hiding this comment.
I see.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
github-actions
Bot
added
the
maintainer-merge
|
Member
|
Thanks 🎉 bors merge |
github-actions
Bot
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2024
The lemmas can easily move to `Algebra.Group.Nat` and `Algebra.Group.Int`, `Algebra.Ring.Int` respectively.
Contributor
|
Build failed (retrying...): |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2024
The lemmas can easily move to `Algebra.Group.Nat` and `Algebra.Group.Int`, `Algebra.Ring.Int` respectively.
Contributor
|
Build failed (retrying...): |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 15, 2024
The lemmas can easily move to `Algebra.Group.Nat` and `Algebra.Group.Int`, `Algebra.Ring.Int` respectively.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Data.Nat.Units, Data.Int.UnitsData.Nat.Units, Data.Int.Units
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
The lemmas can easily move to `Algebra.Group.Nat` and `Algebra.Group.Int`, `Algebra.Ring.Int` respectively.
grunweg
pushed a commit
that referenced
this pull request
May 17, 2024
The lemmas can easily move to `Algebra.Group.Nat` and `Algebra.Group.Int`, `Algebra.Ring.Int` respectively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lemmas can easily move to
Algebra.Group.NatandAlgebra.Group.Int,Algebra.Ring.Intrespectively.