Skip to content

refactor(LinearAlgebra/BilinearForm/Basic): Deprecate - #12112

Closed
mans0954 wants to merge 17 commits into
masterfrom
mans0954/BilinearForm-Basic-deprecate
Closed

refactor(LinearAlgebra/BilinearForm/Basic): Deprecate#12112
mans0954 wants to merge 17 commits into
masterfrom
mans0954/BilinearForm-Basic-deprecate

Conversation

@mans0954

@mans0954 mans0954 commented Apr 13, 2024

Copy link
Copy Markdown
Collaborator

Deprecate most of LinearAlgebra/BilinearForm/Basic.


Open in Gitpod

@mans0954 mans0954 added the WIP Work in progress label Apr 13, 2024
@mans0954 mans0954 changed the title refactor(LinearAlgebra/BilinearForm/Basic): Deprecate coercions refactor(LinearAlgebra/BilinearForm/Basic): Deprecate Apr 13, 2024
@mans0954
mans0954 marked this pull request as ready for review April 13, 2024 22:48
@mans0954 mans0954 added awaiting-review and removed WIP Work in progress labels Apr 13, 2024

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that a lot of these might be worth keeping; the naming is a little odd if you're working with bilinear forms.

The coe lemmas are not, as their statement is nonsense after the last PR.

Comment thread Mathlib/LinearAlgebra/BilinearForm/Basic.lean Outdated
@mans0954

Copy link
Copy Markdown
Collaborator Author

I'd argue that a lot of these might be worth keeping; the naming is a little odd if you're working with bilinear forms.

I did wonder about that. We've ended up with some things in LinearMap.BilinForm and some things with the convention.

I suspect a lot of these things should be LinearMap.BilinMap or even LinearMap.SesquiMap so neither of the current naming conventions may be the final form?

@eric-wieser

eric-wieser commented Apr 14, 2024

Copy link
Copy Markdown
Member

I suspect a lot of these things should be LinearMap.BilinMap or even LinearMap.SesquiMap so neither of the current naming conventions may be the final form?

I would be inclined not to deprecate these until we have a clearer picture of the final form. Perhaps let's create a new PR that deprecates just the nonsense coe lemmas, and leave the this PR until your BilinMap stuff lands?

@mans0954

Copy link
Copy Markdown
Collaborator Author

I would be inclined not to deprecate these until we have a clearer picture of the final form. Perhaps let's create a new PR that deprecates just the nonsense coe lemmas, and leave the this PR until your BilinMap stuff lands?

Okay, what about the _apply theorems?

@eric-wieser

Copy link
Copy Markdown
Member

The apply theorems are good and we should keep them.

@mans0954

Copy link
Copy Markdown
Collaborator Author

Perhaps let's create a new PR that deprecates just the nonsense coe lemmas

#12132

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 16, 2024
@mans0954 mans0954 closed this Apr 16, 2024
@YaelDillies
YaelDillies deleted the mans0954/BilinearForm-Basic-deprecate branch August 15, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants