[Merged by Bors] - chore: Split Data.{Nat,Int}{.Order}.Basic in group vs ring instances - #11924
Closed
YaelDillies wants to merge 13 commits into
Closed
[Merged by Bors] - chore: Split Data.{Nat,Int}{.Order}.Basic in group vs ring instances#11924YaelDillies wants to merge 13 commits into
Data.{Nat,Int}{.Order}.Basic in group vs ring instances#11924YaelDillies wants to merge 13 commits into
Conversation
Scatter the content of `Data.Nat.Basic` across: * `Data.Nat.Defs` for the lemmas having no dependencies * `Algebra.Group.Nat` for the monoid instances and the few miscellaneous lemmas needing them. * `Algebra.Ring.Nat` for the semiring instance and the few miscellaneous lemmas following it. Similarly, scatter * `Data.Int.Basic` across `Data.Int.Defs`, `Algebra.Group.Int`, `Algebra.Ring.Int` * `Data.Nat.Order.Basic` across `Data.Nat.Defs`, `Algebra.Order.Group.Nat`, `Algebra.Order.Ring.Nat` * `Data.Int.Order.Basic` across `Data.Int.Defs`, `Algebra.Order.Group.Int`, `Algebra.Order.Ring.Int` Also move a few lemmas from `Data.Nat.Order.Lemmas` to `Data.Nat.Defs`.
![github-actions[bot]](https://avatars.github.com/in/15368?s=60&v=4){kind=small}
YaelDillies
added
awaiting-review
awaiting-CI
1 task
ghost
added
the
merge-conflict
ghost
removed
the
merge-conflict
github-actions
Bot
removed
the
awaiting-CI
ghost
added
the
merge-conflict
ghost
added
merge-conflict
ghost
removed
the
merge-conflict
16 tasks
ghost
added
the
merge-conflict
Contributor
|
Sorry, just acquired another merge conflict. bors d+ |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
Bot
added
the
delegated
Contributor
Author
|
That was an easy one to fix. bors merge |
Contributor
|
👎 Rejected by label |
YaelDillies
removed
the
merge-conflict
Contributor
Author
|
bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
#11924) Scatter the content of `Data.Nat.Basic` across: * `Data.Nat.Defs` for the lemmas having no dependencies * `Algebra.Group.Nat` for the monoid instances and the few miscellaneous lemmas needing them. * `Algebra.Ring.Nat` for the semiring instance and the few miscellaneous lemmas following it. Similarly, scatter * `Data.Int.Basic` across `Data.Int.Defs`, `Algebra.Group.Int`, `Algebra.Ring.Int` * `Data.Nat.Order.Basic` across `Data.Nat.Defs`, `Algebra.Order.Group.Nat`, `Algebra.Order.Ring.Nat` * `Data.Int.Order.Basic` across `Data.Int.Defs`, `Algebra.Order.Group.Int`, `Algebra.Order.Ring.Int` Also move a few lemmas from `Data.Nat.Order.Lemmas` to `Data.Nat.Defs`. Before  After 
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Data.{Nat,Int}{.Order}.Basic in group vs ring instancesData.{Nat,Int}{.Order}.Basic in group vs ring instances
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
#11924) Scatter the content of `Data.Nat.Basic` across: * `Data.Nat.Defs` for the lemmas having no dependencies * `Algebra.Group.Nat` for the monoid instances and the few miscellaneous lemmas needing them. * `Algebra.Ring.Nat` for the semiring instance and the few miscellaneous lemmas following it. Similarly, scatter * `Data.Int.Basic` across `Data.Int.Defs`, `Algebra.Group.Int`, `Algebra.Ring.Int` * `Data.Nat.Order.Basic` across `Data.Nat.Defs`, `Algebra.Order.Group.Nat`, `Algebra.Order.Ring.Nat` * `Data.Int.Order.Basic` across `Data.Int.Defs`, `Algebra.Order.Group.Int`, `Algebra.Order.Ring.Int` Also move a few lemmas from `Data.Nat.Order.Lemmas` to `Data.Nat.Defs`. Before  After 
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
#11924) Scatter the content of `Data.Nat.Basic` across: * `Data.Nat.Defs` for the lemmas having no dependencies * `Algebra.Group.Nat` for the monoid instances and the few miscellaneous lemmas needing them. * `Algebra.Ring.Nat` for the semiring instance and the few miscellaneous lemmas following it. Similarly, scatter * `Data.Int.Basic` across `Data.Int.Defs`, `Algebra.Group.Int`, `Algebra.Ring.Int` * `Data.Nat.Order.Basic` across `Data.Nat.Defs`, `Algebra.Order.Group.Nat`, `Algebra.Order.Ring.Nat` * `Data.Int.Order.Basic` across `Data.Int.Defs`, `Algebra.Order.Group.Int`, `Algebra.Order.Ring.Int` Also move a few lemmas from `Data.Nat.Order.Lemmas` to `Data.Nat.Defs`. Before  After 
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
#11924) Scatter the content of `Data.Nat.Basic` across: * `Data.Nat.Defs` for the lemmas having no dependencies * `Algebra.Group.Nat` for the monoid instances and the few miscellaneous lemmas needing them. * `Algebra.Ring.Nat` for the semiring instance and the few miscellaneous lemmas following it. Similarly, scatter * `Data.Int.Basic` across `Data.Int.Defs`, `Algebra.Group.Int`, `Algebra.Ring.Int` * `Data.Nat.Order.Basic` across `Data.Nat.Defs`, `Algebra.Order.Group.Nat`, `Algebra.Order.Ring.Nat` * `Data.Int.Order.Basic` across `Data.Int.Defs`, `Algebra.Order.Group.Int`, `Algebra.Order.Ring.Int` Also move a few lemmas from `Data.Nat.Order.Lemmas` to `Data.Nat.Defs`. Before  After 
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
#11924) Scatter the content of `Data.Nat.Basic` across: * `Data.Nat.Defs` for the lemmas having no dependencies * `Algebra.Group.Nat` for the monoid instances and the few miscellaneous lemmas needing them. * `Algebra.Ring.Nat` for the semiring instance and the few miscellaneous lemmas following it. Similarly, scatter * `Data.Int.Basic` across `Data.Int.Defs`, `Algebra.Group.Int`, `Algebra.Ring.Int` * `Data.Nat.Order.Basic` across `Data.Nat.Defs`, `Algebra.Order.Group.Nat`, `Algebra.Order.Ring.Nat` * `Data.Int.Order.Basic` across `Data.Int.Defs`, `Algebra.Order.Group.Int`, `Algebra.Order.Ring.Int` Also move a few lemmas from `Data.Nat.Order.Lemmas` to `Data.Nat.Defs`. Before  After 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scatter the content of
Data.Nat.Basicacross:Data.Nat.Defsfor the lemmas having no dependenciesAlgebra.Group.Natfor the monoid instances and the few miscellaneous lemmas needing them.Algebra.Ring.Natfor the semiring instance and the few miscellaneous lemmas following it.Similarly, scatter
Data.Int.BasicacrossData.Int.Defs,Algebra.Group.Int,Algebra.Ring.IntData.Nat.Order.BasicacrossData.Nat.Defs,Algebra.Order.Group.Nat,Algebra.Order.Ring.NatData.Int.Order.BasicacrossData.Int.Defs,Algebra.Order.Group.Int,Algebra.Order.Ring.IntAlso move a few lemmas from
Data.Nat.Order.LemmastoData.Nat.Defs.Before
After
