[Merged by Bors] - chore: remove Complex/RCLike bit0/1 lemmas - #11414
Closed
Ruben-VandeVelde wants to merge 9 commits into
Closed
[Merged by Bors] - chore: remove Complex/RCLike bit0/1 lemmas#11414Ruben-VandeVelde wants to merge 9 commits into
Ruben-VandeVelde wants to merge 9 commits into
Conversation
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
reviewed
Mar 17, 2024
eric-wieser
left a comment
eric-wieser
left a comment
Member
There was a problem hiding this comment.
I think every bit0/bit1 pair should be replaced by an ofNat lemma
eric-wieser
added
awaiting-author
Contributor
Author
These already existed except for conj (though |
eric-wieser
approved these changes
Mar 17, 2024
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Ruben-VandeVelde
added
awaiting-review
awaiting-CI
github-actions
Bot
removed
the
awaiting-CI
ghost
added
the
merge-conflict
ghost
added
merge-conflict
ghost
removed
the
merge-conflict
Contributor
|
Can you change |
dupuisf
changed the title
ghost
added
the
merge-conflict
Ruben-VandeVelde
removed
the
merge-conflict
Contributor
Author
|
Done, thanks |
Contributor
|
Thanks! bors r+ |
github-actions
Bot
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
These were interesting when they worked on number literals, which is no longer the case in lean4.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Closed
3 tasks
YaelDillies
reviewed
Apr 7, 2024
Comment on lines
+183
to
+188
| -- replaced by `RCLike.ofNat_re` | ||
| #noalign is_R_or_C.bit0_re | ||
| #noalign is_R_or_C.bit1_re | ||
| -- replaced by `RCLike.ofNat_im` | ||
| #noalign is_R_or_C.bit0_im | ||
| #noalign is_R_or_C.bit1_im |
Contributor
There was a problem hiding this comment.
Why disregard the align mechanism?
Suggested change
| -- replaced by `RCLike.ofNat_re` | |
| #noalign is_R_or_C.bit0_re | |
| #noalign is_R_or_C.bit1_re | |
| -- replaced by `RCLike.ofNat_im` | |
| #noalign is_R_or_C.bit0_im | |
| #noalign is_R_or_C.bit1_im | |
| #align is_R_or_C.bit0_re RCLike.ofNat_re | |
| #align is_R_or_C.bit1_re RCLike.ofNat_re | |
| #align is_R_or_C.bit0_im RCLike.ofNat_im | |
| #align is_R_or_C.bit1_im RCLike.ofNat_im |
Same below
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
These were interesting when they worked on number literals, which is no longer the case in lean4.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
These were interesting when they worked on number literals, which is no longer the case in lean4.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
These were interesting when they worked on number literals, which is no longer the case in lean4.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
These were interesting when they worked on number literals, which is no longer the case in lean4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were interesting when they worked on number literals, which is no longer the case in lean4.