refactor(GroupTheory/Submonoid/Operations): Use SubmonoidClass and delete redundant instances - #11304
Closed
tb65536 wants to merge 14 commits into
Closed
refactor(GroupTheory/Submonoid/Operations): Use SubmonoidClass and delete redundant instances#11304tb65536 wants to merge 14 commits into
SubmonoidClass and delete redundant instances#11304tb65536 wants to merge 14 commits into
Conversation
tb65536
added
awaiting-review
awaiting-CI
This reverts commit eee52d6. revert
github-actions
Bot
removed
the
awaiting-CI
Member
|
This seems like a good move. Let's also bench it. !bench |
Member
|
!bench |
Collaborator
|
Here are the benchmark results for commit b3d2126. Benchmark Metric Change
===================================================
- build wall-clock 22.2%
- ~Mathlib.Algebra.Module.PID instructions 5.7% |
Member
|
Maybe not so good an idea! |
Member
|
@tb65536 Given this bench result, what do you think? Do you want to attempt to improve performance, or shall we punt on this? |
jcommelin
added
awaiting-author
ghost
added
the
merge-conflict
Contributor
Author
|
Probably just punt for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors some
SMulinstances inGroupTheory/Submonoid/Operations.leanto useSubmonoidClass. This makes many other similar instances redundant.