Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(linear_algebra/quadratic_form): provide distrib_mul_action S (quadratic_form M R) when S has no addition. - #7443

Closed
eric-wieser wants to merge 5 commits into
masterfrom
eric-wieser/quadratic-form-relax
Closed

[Merged by Bors] - feat(linear_algebra/quadratic_form): provide distrib_mul_action S (quadratic_form M R) when S has no addition.#7443
eric-wieser wants to merge 5 commits into
masterfrom
eric-wieser/quadratic-form-relax

Conversation

@eric-wieser

@eric-wieser eric-wieser commented May 3, 2021

Copy link
Copy Markdown
Member

The end goal here is to provide has_scalar (units R) (quadratic_form M R) for possible use in #7427


Open in Gitpod

This lemma did not need a full algebra structure; written this way, it permits usage on `has_scalar (units R) A` given `algebra R A` (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.

@Vierkantor Vierkantor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@bors

bors Bot commented May 4, 2021

Copy link
Copy Markdown

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions Bot added delegated The PR author may merge after reviewing final suggestions. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 4, 2021
@github-actions

github-actions Bot commented May 6, 2021

Copy link
Copy Markdown

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@jcommelin jcommelin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

bors Bot pushed a commit that referenced this pull request May 6, 2021
…uadratic_form M R)` when `S` has no addition. (#7443)

The end goal here is to provide `has_scalar (units R) (quadratic_form M R)` for possible use in #7427
@github-actions github-actions Bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 6, 2021
@bors

bors Bot commented May 6, 2021

Copy link
Copy Markdown

This PR was included in a batch that was canceled, it will be automatically retried

bors Bot pushed a commit that referenced this pull request May 6, 2021
…uadratic_form M R)` when `S` has no addition. (#7443)

The end goal here is to provide `has_scalar (units R) (quadratic_form M R)` for possible use in #7427
@bors

bors Bot commented May 6, 2021

Copy link
Copy Markdown

Build failed (retrying...):

bors Bot pushed a commit that referenced this pull request May 7, 2021
…uadratic_form M R)` when `S` has no addition. (#7443)

The end goal here is to provide `has_scalar (units R) (quadratic_form M R)` for possible use in #7427
bors Bot pushed a commit that referenced this pull request May 7, 2021
…uadratic_form M R)` when `S` has no addition. (#7443)

The end goal here is to provide `has_scalar (units R) (quadratic_form M R)` for possible use in #7427
@bors

bors Bot commented May 7, 2021

Copy link
Copy Markdown

Pull request successfully merged into master.

Build succeeded:

@bors bors Bot changed the title feat(linear_algebra/quadratic_form): provide distrib_mul_action S (quadratic_form M R) when S has no addition. [Merged by Bors] - feat(linear_algebra/quadratic_form): provide distrib_mul_action S (quadratic_form M R) when S has no addition. May 7, 2021
@bors bors Bot closed this May 7, 2021
@bors
bors Bot deleted the eric-wieser/quadratic-form-relax branch May 7, 2021 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants