Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(order/directed): Scott continuous functions - #18517

Closed
mans0954 wants to merge 30 commits into
masterfrom
mans0954/directed-on-insert
Closed

[Merged by Bors] - feat(order/directed): Scott continuous functions#18517
mans0954 wants to merge 30 commits into
masterfrom
mans0954/directed-on-insert

Conversation

@mans0954

@mans0954 mans0954 commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

We prove an insert result for directed sets when the relation is reflexive. This is then used to show that a Scott continuous function is monotone.

This result is required in the construction of the Scott topology on a preorder (see also #18448).

Holding PR for mathlib4: leanprover-community/mathlib4#2543


Open in Gitpod

@YaelDillies

Copy link
Copy Markdown
Collaborator

@vihdzp, any chance this interacts positively with ordinal.is_normal?

@vihdzp

vihdzp commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

Ordinal functions are strictly monotone, but this might still come in handy for some ordinal results.

@mans0954 mans0954 added the awaiting-review The author would like community review of the PR label Mar 1, 2023
Comment thread src/order/directed.lean Outdated
Comment thread src/order/directed.lean Outdated
Comment thread src/order/directed.lean Outdated
Comment thread src/order/directed.lean Outdated
mans0954 and others added 6 commits March 2, 2023 18:49
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This reverts commit 7046749.
Comment thread src/order/directed.lean Outdated
Comment thread src/order/directed.lean Outdated
mans0954 and others added 5 commits March 11, 2023 20:53
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a handful of golfs.

Comment thread src/order/directed.lean Outdated
@mans0954

Copy link
Copy Markdown
Collaborator Author

I pushed a handful of golfs.

Thank you!

@kim-em kim-em added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Mar 28, 2023

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors

bors Bot commented Apr 19, 2023

Copy link
Copy Markdown

✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 19, 2023
mans0954 and others added 3 commits April 19, 2023 20:21
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Comment thread src/order/directed.lean Outdated
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mans0954

Copy link
Copy Markdown
Collaborator Author

Lint seems to be failing in CI due to apt being unable to retrieve a package:

Err:6 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 libgs9-common all 9.55.0~dfsg1-0ubuntu5.1
  404  Not Found [IP: 40.119.46.219 80]
Err:10 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 libgs9 amd64 9.55.0~dfsg1-0ubuntu5.1
  404  Not Found [IP: 40.119.46.219 80]
Fetched 59.5 MB in 4s (16.8 MB/s)
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/g/ghostscript/libgs9-common_9.55.0%7edfsg1-0ubuntu5.1_all.deb  404  Not Found [IP: 40.119.46.219 80]
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/g/ghostscript/libgs9_9.55.0%7edfsg1-0ubuntu5.1_amd64.deb  404  Not Found [IP: 40.119.46.219 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

I've tried re-running a couple of times, but always the same result.

@mans0954

Copy link
Copy Markdown
Collaborator Author

Lint seems to be failing in CI due to apt being unable to retrieve a package:

Merging latest master seems to have fixed it.

@YaelDillies

Copy link
Copy Markdown
Collaborator

Yeah, this was fixed on Zulip a few days ago.

@mans0954

Copy link
Copy Markdown
Collaborator Author

bors r+

bors Bot pushed a commit that referenced this pull request Apr 20, 2023
We prove an insert result for directed sets when the relation is reflexive. This is then used to show that a Scott continuous function is monotone.

This result is required in the [construction of the Scott topology on a preorder](leanprover-community/mathlib4#2508) (see also #18448).

Holding PR for mathlib4: leanprover-community/mathlib4#2543



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors

bors Bot commented Apr 20, 2023

Copy link
Copy Markdown

Pull request successfully merged into master.

Build succeeded:

@bors bors Bot changed the title feat(order/directed): Scott continuous functions [Merged by Bors] - feat(order/directed): Scott continuous functions Apr 20, 2023
@bors bors Bot closed this Apr 20, 2023
@bors
bors Bot deleted the mans0954/directed-on-insert branch April 20, 2023 14:40
@mans0954

Copy link
Copy Markdown
Collaborator Author

@YaelDillies , @eric-wieser - for the Mathlib4 port, should I expect the equivalent file in mathlib3port to get updated automatically? (This doesn't seem to have happened yet.)

@YaelDillies

Copy link
Copy Markdown
Collaborator

Yes, it will happen in about 8 hours from now.

@mans0954

Copy link
Copy Markdown
Collaborator Author

Yes, it will happen in about 8 hours from now.

Thanks - and then I manually copy over the changes into leanprover-community/mathlib4#2543, fixing any issues as necessary?

@YaelDillies

Copy link
Copy Markdown
Collaborator

Yes, exactly. Also note that you don't need to fetch the changes yourself. You can just wait for the bump to nightly-2023-04-21-04 (or something like that) entry in the mathlib3port column at https://leanprover-community.github.io/mathlib-port-status/file/order/directed to appear.

bors Bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 24, 2023
Matches leanprover-community/mathlib3#18517

This result is required in #2508.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 10, 2023
Matches leanprover-community/mathlib3#18517

This result is required in #2508.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 10, 2023
Matches leanprover-community/mathlib3#18517

This result is required in #2508.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
hrmacbeth pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 11, 2023
Matches leanprover-community/mathlib3#18517

This result is required in #2508.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors Bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Sep 15, 2023
…lies OmegaCompletePartialOrder.Continuous' (#6831)

In leanprover-community/mathlib3#18517 we introduced the notion of a Scott Continuous function between preorders. This PR shows that a Scott Continuous function between OmegaCompletePartialOrders is necessarily `OmegaCompletePartialOrder.Continuous'`.



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
kodyvajjha pushed a commit to leanprover-community/mathlib4 that referenced this pull request Sep 22, 2023
…lies OmegaCompletePartialOrder.Continuous' (#6831)

In leanprover-community/mathlib3#18517 we introduced the notion of a Scott Continuous function between preorders. This PR shows that a Scott Continuous function between OmegaCompletePartialOrders is necessarily `OmegaCompletePartialOrder.Continuous'`.



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants