[leancode_analytics_posthog] Send one $screen event per navigation - #563
Open
zoskar wants to merge 2 commits into
Open
[leancode_analytics_posthog] Send one $screen event per navigation#563zoskar wants to merge 2 commits into
zoskar wants to merge 2 commits into
Conversation
The observer sent its own screen view for the `LeanAnalyticsRoute` id and then delegated to `PosthogObserver`, which sent a second one named after `RouteSettings.name`. Suppressing the inherited screen view with a null `nameExtractor` keeps the superclass bookkeeping intact.
Member
|
@zoskar I think a more "complete" fix would be to implement support for parameters in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LeanAnalyticsPostHogObserversends a$screenfor theLeanAnalyticsRouteid, then callssuper,which makes
PosthogObserversend a second one named afterRouteSettings.name.One navigation, two events, two naming schemes — in an auto_route app that's
loginPageandLoginRoutefor the same push. Screen view counts come out doubled and split across both names.It only surfaces when routes carry a non-empty
RouteSettings.name;PosthogObserverskips therest, which is why the package can look fine in projects that don't name their routes.
Fix
Pass a
nameExtractorthat returnsnull, so the inherited screen view is suppressed whilePosthogObserver's own bookkeeping — survey context, route subscriptions — still runs.Routes that don't implement
LeanAnalyticsRoutestop being tracked, which is what the class alreadydocuments.