Skip to content

docs(mail): remove get_signatures from skill reference - #545

Merged
chanthuang merged 1 commit into
mainfrom
docs/mail-remove-get-signatures
Apr 22, 2026
Merged

docs(mail): remove get_signatures from skill reference#545
chanthuang merged 1 commit into
mainfrom
docs/mail-remove-get-signatures

Conversation

@chanthuang

@chanthuang chanthuang commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • get_signatures is not directly exposed as a CLI command — it's wrapped by +signature
  • Remove the raw get_signatures entry from the shortcut reference list and the permissions table in skills/lark-mail/SKILL.md

Summary by CodeRabbit

  • Documentation
    • Removed the get_signatures API method documentation from lark-cli mail.

…signature instead

Change-Id: I3463cbd08d595c1cb9cda4fadc6e2a5ad1c62189
@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 85e650aa-0abe-4bcc-968f-766dc8bce2e2

📥 Commits

Reviewing files that changed from the base of the PR and between 4f90fd3 and 56840a3.

📒 Files selected for processing (1)
  • skills/lark-mail/SKILL.md
💤 Files with no reviewable changes (1)
  • skills/lark-mail/SKILL.md

📝 Walkthrough

Walkthrough

The documentation for the Lark Mail CLI was updated to remove the get_signatures method from the user_mailbox.settings API resource and its associated permission scope entry.

Changes

Cohort / File(s) Summary
Lark Mail API Documentation
skills/lark-mail/SKILL.md
Removed user_mailbox.settings.get_signatures API method documentation entry and its corresponding permission scope (mail:user_mailbox:readonly) from the resource table.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A signature erased with care,
From docs so clean, with space to spare,
No method lost, just trimmed with grace,
Simplicity wins the coding race!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is missing required sections (Changes, Test Plan, Related Issues) from the template, though it does provide a summary explaining the rationale for the removal. Add the missing sections from the template: a bulleted Changes list, Test Plan with checkboxes, and Related Issues section to provide complete documentation.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing get_signatures from the mail skill documentation reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/mail-remove-get-signatures

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact labels Apr 17, 2026
@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@56840a3f7d319eb3ec16e08c85c5999e9459091e

🧩 Skill update

npx skills add larksuite/cli#docs/mail-remove-get-signatures -y -g

Comment thread skills/lark-mail/SKILL.md

@infeng infeng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No issues found.

Review baseline: base main, head docs/mail-remove-get-signatures (56840a3).

@chanthuang
chanthuang merged commit 462d38e into main Apr 22, 2026
20 checks passed
@chanthuang
chanthuang deleted the docs/mail-remove-get-signatures branch April 22, 2026 08:08
@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.91%. Comparing base (4f90fd3) to head (56840a3).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   59.91%   59.91%           
=======================================
  Files         388      388           
  Lines       33147    33147           
=======================================
  Hits        19859    19859           
  Misses      11420    11420           
  Partials     1868     1868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tuxedomm pushed a commit to zhumiaoxin/cli that referenced this pull request Jun 6, 2026
…signature instead (larksuite#545)

Change-Id: I3463cbd08d595c1cb9cda4fadc6e2a5ad1c62189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants