Fix compilation in multi-version php environment#518
Merged
Conversation
Contributor
Author
|
@owenvoke test failure is unrelated to my PR |
Contributor
Author
|
@owenvoke any chance you can look at this? |
owenvoke
approved these changes
Mar 24, 2026
owenvoke
left a comment
Member
There was a problem hiding this comment.
This makes sense to me. 👍🏻 I've actually considered doing this previously, and not too sure why I didn't. 🤔
Member
|
Released as part of v12.1.0, thanks @rforced! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an environment where multiple versions of PHP is installed.
The default /usr/bin/php is PHP 8.5. In there is also /usr/bin/php84, 83, etc.
When you compile an app when the environment default is 8.5 (box is still broken on PHP 8.5),
php84 ./application app:build -vvv --build-version=0.1
Will still fail, because we don't pass the wanted php to box.
This now passes the wanted php version to execute box with.
With this change, it will respect what version was "passed" in the command line. This also still works on Windows.
Please let me know if you have any questions.