Remove dynamic properties to remove PHP 8.2 deprecation warnings - #75
Merged
Merged
Conversation
…e classes Signed-off-by: Ádám Bálint <adam.balint@srg.hu>
samsonasik
reviewed
Nov 23, 2022
Signed-off-by: Ádám Bálint <adam.balint@srg.hu>
Signed-off-by: Ádám Bálint <adam.balint@srg.hu>
Ocramius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ádám Bálint adam.balint@srg.hu
In PHP 8.2 dynamic properties will be deprecated. I found two dynamic properties, and as I see these properties aren't used, only set. I know that because of the dynamic declaration these properties will be public, so there is the possibility that someone uses these properties. This is why it can be BC break.
Or should I create these public properties in these classes?