Skip to content

Drop support for PHP 8.1, Add support for PHP 8.5 - #116

Merged
gsteel merged 17 commits into
laminas:2.23.xfrom
cod62627:PHP8.5-support
Dec 5, 2025
Merged

Drop support for PHP 8.1, Add support for PHP 8.5#116
gsteel merged 17 commits into
laminas:2.23.xfrom
cod62627:PHP8.5-support

Conversation

@cod62627

Copy link
Copy Markdown
Contributor
Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

Signed-off-by: Bhavin Parmar <cod62627@adobe.com>
Signed-off-by: Bhavin Parmar <cod62627@adobe.com>
Signed-off-by: Bhavin Parmar <cod62627@adobe.com>
Signed-off-by: Bhavin Parmar <cod62627@adobe.com>
@github-project-automation github-project-automation Bot moved this to Todo in PHP 8.5 Oct 29, 2025
@froschdesign
froschdesign marked this pull request as draft October 29, 2025 19:29
cod62627 and others added 10 commits November 3, 2025 15:56
Signed-off-by: Bhavin Parmar <cod62627@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
@cod62627

cod62627 commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

@froschdesign

We've completed the work to add PHP 8.5 support, and the PR is now ready for review and merge.
Could you please take a look and share your feedback or any suggestions for improvement?

Currently there are two errors regarding laminas-uri which we have fixed in the PR: laminas/laminas-uri#26

Thank you for your support!

Signed-off-by: sandesh.as <cod48668@adobe.com>
@k00ni

k00ni commented Nov 19, 2025

Copy link
Copy Markdown

Looks good to me. I use this library in my EasyRdf fork (https://github.com/sweetrdf/easyrdf) and it would be great to get this merged and have PHP 8.5 support soon. Thanks for the work 👍

@arhimede

Copy link
Copy Markdown
Member

Looks good to me. I use this library in my EasyRdf fork (https://github.com/sweetrdf/easyrdf) and it would be great to get this merged and have PHP 8.5 support soon. Thanks for the work 👍

There are failed checks, PHPUnit ...
Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead

@froschdesign

Copy link
Copy Markdown
Member

@cod62627
Can you recheck the problems on PHP 8.5?
Thanks in advance! 👍🏻

@sandesh-as

Copy link
Copy Markdown
Contributor

@cod62627 Can you recheck the problems on PHP 8.5? Thanks in advance! 👍🏻

@froschdesign As the issue /github/workspace/vendor/laminas/laminas-uri/src/Http.php:203 Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead is comming in the Uri module, we have fixed it in this PR #26

@gsteel

gsteel commented Dec 5, 2025

Copy link
Copy Markdown
Member

laminas/laminas-uri#26 is merged, could you please refresh the lock file and push 👍

Signed-off-by: sandesh.as <cod48668@adobe.com>
Signed-off-by: sandesh.as <cod48668@adobe.com>
@sandesh-as

Copy link
Copy Markdown
Contributor

@gsteel Done

@froschdesign froschdesign changed the title PHP8.5 Support Added Drop support for PHP 8.1, Add support for PHP 8.5 Dec 5, 2025
@gsteel gsteel self-assigned this Dec 5, 2025

@gsteel gsteel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cod62627 and @sandesh-as

@gsteel gsteel added the Dependencies Updates and changes to dependencies label Dec 5, 2025
@gsteel gsteel added this to the 2.23.0 milestone Dec 5, 2025
@gsteel
gsteel merged commit fc66836 into laminas:2.23.x Dec 5, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in PHP 8.5 Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Updates and changes to dependencies Enhancement

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants