Working with nullable properties.

[todo-username]

Bug Report

Q	A
Version(s)	4.13.0

Summary

When creating methods with arguments that accept NULL, an additional '\' character is inserted.

Current behavior

When creating methods with arguments that accept NULL, an additional '\' character is inserted.

This behavior is most likely due to this method

src/Generator/TypeGenerator/AtomicType.php

If you remove the substitution of these characters, the method is generated correctly

Most likely, these characters are removed incorrectly if use ClassName is present in the class. If you create properties without the '?' The extra '\' is not added.

How to reproduce

Try creating methods for nullable properties (not primitives).

Expected behavior

The method is created without the additional '\' character.

[Ocramius]

Are you able to write a snippet that runs the generator and reproduces the problem here? I can't understand how laminas/laminas-code is used in your example.

Also, \ArrayCollection is correct if 'ArrayCollection' is given as string. All class names are assumed to be FQCNs, and I'd say that the property not having the \ is more problematic there.

[todo-username]

Also, \ArrayCollection is correct if 'ArrayCollection' is given as string.

@Ocramius Yes, it is passed as a string, because if you pass the full class path, an additional prefix will be written, which is not needed due to the use of 'use'

[todo-username]

Are you able to write a snippet that runs the generator and reproduces the problem here? I can't understand how laminas/laminas-code is used in your example.

@Ocramius Can you give an example of a format that will make it easier for you to understand the problem?

[Ocramius]

Also, \ArrayCollection is correct if 'ArrayCollection' is given as string.

@Ocramius Yes, it is passed as a string, because if you pass the full class path, an additional prefix will be written, which is not needed due to the use of 'use'

laminas/laminas-code explicitly does NOT consider use statements: all symbols are FQN (fully qualified name) references.

More in #176

Can you give an example of a format that will make it easier for you to understand the problem?

The best you can do to reproduce the problem is:

1. clone this repository
2. make an example for ClassGenerator (see https://github.com/laminas/laminas-code/blob/fd87696ee3c03073058ee26176d0a7049930fefe/test/Generator/ClassGeneratorTest.php)
3. make it fail with your scenario, to highlight the expectation differences

BTW, don't paste in screenshots: they are terrible to process :D You can use triple backticks for a code snippet.

That said, I endorse checking #176 first.