Reject overflowing digit recompositions - #98
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
krotname
deleted the
codex/fix-silent-integer-overflow-in-digit-recomposition
branch
August 1, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
intarithmetic.Description
DescendingOrder.sortDescto build the reordered digits with aStringBuilderand returnInteger.parseInt(...)so values outsideintrange throwNumberFormatException.MinimumLine.minValueto concatenate sorted distinct values viamapToObj(String::valueOf)andCollectors.joining()and returnInteger.parseInt(...)to preserve concatenation semantics and reject overflow.rejectsReorderedValuesOutsideIntegerRangeinDescendingOrderTestandrejectsConcatenatedValuesOutsideIntegerRangeinMinimumLineTestthat assert aNumberFormatExceptionis thrown for the reported overflowing inputs.Testing
mvn -q -Dtest=DescendingOrderTest,MinimumLineTest testand the targeted tests passed.mvn -q testand it completed successfully in this environment.git diff --checkto validate no whitespace/diff issues and the working tree was clean.Codex Task