Prevent RecursionMax stack exhaustion - #97
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
recursionMax(List<Integer>)previously used unbounded recursion and attempted to remove elements from the inputList, which can throwUnsupportedOperationExceptionfor fixed-size/immutable lists and can causeStackOverflowErroron very large lists.Description
recursionMax(List<Integer>)through the existing iterativemax(List<Integer>)implementation so the method no longer mutates the caller's list or performs unbounded recursion.recursionMaxreturns the same values asmaxfornull, empty, single-element, and multi-element lists.shouldHandleLargeListsWithoutExhaustingTheStackthat usesCollections.nCopies(100_000, 42)to verify large caller-controlled lists are handled without stack exhaustion and without mutating the input.Testing
mvn -Dtest=other.RecursionMaxTest testand the modifiedRecursionMaxtests passed.mvn verifyand the build completed successfully with 598 tests passing and Checkstyle, PMD, JaCoCo, and SpotBugs gates all passing.Codex Task