Prevent stack overflow in BST deletion - #90
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution.remove(Node,int)implementation used unbounded recursion proportional to tree height, which can triggerStackOverflowErroron deeply skewed (attacker-controlled) trees and cause availability failures.Description
parentandcurrentpointers to avoid per-level Java stack frames during traversal.findMax/recursive-delete path and return/update child links iteratively; overall auxiliary space becomes O(1).removeHandlesDeepSkewedTreeWithoutOverflowingStackthat constructs a 100,000-node right-skewed tree and deletes the deepest node to verify no stack overflow and correct tree shape.Testing
mvn -Dtest=algorithms.sprint5.SolutionTest test, and the module-specific tests passed (5 tests, all successful).mvn test, and all automated tests passed (598 tests, all successful).Codex Task