Harden sprint4 CLI solvers against input-driven DoS and unbounded allocation - #84
Closed
krotname wants to merge 1 commit into
Closed
Harden sprint4 CLI solvers against input-driven DoS and unbounded allocation#84krotname wants to merge 1 commit into
krotname wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d47ca83d2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
krotname
deleted the
codex/propose-fix-for-input-driven-dos-vulnerability
branch
August 1, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Map: add a per-process randomHASH_SEEDand mix keys before bucket selection to mitigate attacker-controlled collision chains, addMAX_COMMANDS, replace accumulatedStringBuilderoutput with streamedBufferedWriter, add bounded and validated integer parsing (nextInt(min,max)), validate commands, and move CLI logic intosolve()wrapped by a safemainthat rejects invalid/excessive input.FindSystem: introduceMAX_DOCUMENTS,MAX_QUERIES, andMAX_LINE_LENGTH, enforce these limits innextInt(max)andnextLine(maxLength), stream per-query output withBufferedWriter, and catchIOExceptioninmainso oversized or malformed input is rejected without exhausting resources.Testing
javac -d /tmp/cwjclasses src/main/java/algorithms/sprint4/Map.java src/main/java/algorithms/sprint4/FindSystem.javaand compilation succeeded.algorithms.sprint4.Mapandalgorithms.sprint4.FindSystemand observed expected outputs.nnow triggers a controlledIOExceptionrather than exhausting heap).mvn testwhich completed successfully (546tests run,0failures/errors).Codex Task