fix: remove duplicate keyID on failure and add details when failing to rotate API keys

[mbevc1]

Couple of small cosmetic fixes, following server fix to properly report API errors now.

[claude]

Claude finished @mbevc1's task in 2m 3s —— View job

---

Review: PR #956 — remove duplicate keyID & add details when failing to rotate

• Static analysis (build, vet)
• Review code changes
• Post review feedback

Static analysis

Check	Result
go build ./...	✅ pass
go vet ./cmd/kosli/	✅ pass

Summary

This is a clean, small fix and the test changes from the latest push resolve the test-breakage I flagged in the previous run — all four golden regexes now match the new error strings:

• rotate 404 → Error: failed to rotate API key: API key not found ✅
• delete 404 → failed to delete API key: API key not found ✅
• both partial-failure suites updated accordingly ✅

I couldn't execute the suite here (the api-key tests run under TestApiKeyCommandTestSuite, whose SetupTest needs the local Kosli server + KOSLI_API_TOKEN_PROD per CLAUDE.md), but I verified statically that each regex matches the new output produced by the changed fmt.Errorf calls.

Notes

• ✅ Wrapping the rotate error with fmt.Errorf("failed to rotate API key: %w", err) is a genuine improvement — it adds the missing context and makes rotate consistent with delete. The collected-keys-before-failure behaviour is preserved (break then print).
• 🟡 Minor / non-blocking: removing keyID from the delete message means a multi-key delete no longer names the failing key (reportAlreadyDeleted only lists keys deleted before the failure). The test fixture's server error doesn't carry the ID either. Fine if the real server response now includes the ID — otherwise consider keeping failed to delete API key %s: %w. Left an inline note on deleteApiKey.go:121.

Suggestions

• Consider adding make lint to your local check before merge — I'm limited to build/vet in this environment.

Overall: 👍 looks good to merge once the multi-key delete identification point above is confirmed as intended.