fix(api-keys): inline confirmation prompt and unify message style#948
Merged
Conversation
The prompt no longer ends with a newline, so the answer is typed on the same line. The cancellation message is now capitalised and the key IDs use the same styling as the prompt.
Contributor
|
Claude finished @mbevc1's task in 2m 17s —— View job Review: PR #948 — inline confirmation prompt & unified message style
Solid, focused change. It also resolves the coupling concern raised in the previous review: styling decision and the write target now both go through What's good
Minor / non-blocking
Tests
No blocking issues — nice cleanup. |
ToreMerkely
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.