feat: add linux/s390x build target to release distribution#930
Merged
dangrondahl merged 1 commit intoJun 3, 2026
Merged
Conversation
Adds linux/s390x to the GoReleaser build matrix so the CLI can be installed natively on IBM Z hosts. Skips s390x for darwin/windows and for the npm post-hook (no npm package for s390x). Closes #929
Contributor
|
Claude finished @dangrondahl's task in 4m 10s —— View job PR Review: Add linux/s390x build target
Static AnalysisAll checks pass:
ReviewThis PR looks good. The change is minimal and well-scoped — a single config file with clear intent. What's correct:
One minor observation (non-blocking): The post-hook reorders No issues found. Clean, minimal change with appropriate handling of the npm packaging edge case. LGTM. |
mbevc1
approved these changes
Jun 3, 2026
Contributor
|
@dangrondahl bumping to go 1.26.4 should fix Snyk flagged vulnerability |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux/s390xto the GoReleaser build matrix so IBM Z users can install the CLI nativelys390xfordarwinandwindows(not supported / not needed)s390xsince we don't publish an npm package for that archCloses #929
Test plan
GOOS=linux GOARCH=s390x CGO_ENABLED=0 go buildproduces a 64-bit s390x ELF binarys390x/alpineDocker container;kosli --versionsucceedslinux/s390xarchive +.deb/.rpmartifacts