fix(KNO-9523): import jose statically - #124
Merged
mattmikolay merged 2 commits intoAug 19, 2025
Merged
Conversation
mattmikolay
commented
Aug 19, 2025
| @@ -0,0 +1 @@ | |||
| nodejs 20.19.4 | |||
Contributor
Author
There was a problem hiding this comment.
My local machine was using Node v20.9.0, which does not have the ability to require ES modules enabled by default. This led to build failures and test run failures.
So, to avoid having to pass in the --experimental-require-module flag everywhere, I’m adding a .tool-versions file that uses v20.9.
mattmikolay
marked this pull request as ready for review
August 19, 2025 21:33
mattmikolay
requested review from
connorlindsey,
kylemcd and
meryldakin
and removed request for
a team
August 19, 2025 21:33
connorlindsey
approved these changes
Aug 19, 2025
kylemcd
approved these changes
Aug 19, 2025
mattmikolay
deleted the
mattmik-kno-9523-node-sdk-import-jose-statically
branch
August 19, 2025 22:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
lib/tokenSigner.tsto importjosestatically rather than dynamically. This is safe becausejoseis no longer an optional peer dependency in this codebase.It remains TBD if this will make our token signing work with Node’s experimental support for loading ES modules using
require, becausejose’s README does in fact indicate it should.