chore(kno-11767): update outbound webhook event_data documentation - #1329
Conversation
…s and rework the outbound webhook event types page
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cellomatt
left a comment
There was a problem hiding this comment.
I love the nested attributes update here, I think that makes a lot of sense and it definitely makes the page clearer.
A couple notes:
- It's true that we don't document a shared
EventDataschema that we can link to (because in the API it's thedataon aMessageEvent), and the parameters that are included in theEventDatawill differ based on the type of the event. However,EventDatais a type that we return on the webhook (i.e."__typename": "EventData"), so I think that's the semantically-correct way to document it. If you feel strongly otherwise I think we should get a second opinion just to make sure 👍 - As far as I'm aware, there could also be some variations between providers and whether or not this additional data is available, so I think we should adjust the language on the callout to make it clearer that:
EventDatais not present on every event type, and will benullwhen it isn't available- The availability or content of the data can vary by provider
|
@cellomatt thanks for reviewing 🙌
|
cellomatt
left a comment
There was a problem hiding this comment.
:chefs-kiss:
Great update, thank you!!
Description
These changes update the outbound webhook docs to address recent customer confusion about the use of the
EventDatatype forevent_data. This also makes changes to the<Attributes>component to allow for optional, nested content in a collapsible section.message.undelivered(since we previously usedmessage.sentwhich wasn't an event type that actually includedevent_dataso it was potentially misleading).event_datawould look like.event_dataand that it is null for most event types.event_data,and its presence being event type specific.type="EventData"totype="object"since there is no shared EventData schema.message.delivery_attemptedto clarify that it might be absentevent_dataattributes in an expandable field, which is detailed below.<Attributes>component so that a single<Attribute>could show optional nested content in a collapsible section, similar to what we do in the API reference docs with "Show possible types"Tasks
KNO-11767
Screenshots
Before:

After:
