Add shared histogram buckets for duration metrics#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Note
Medium Risk
Changes histogram bucket boundaries for multiple exported duration metrics, which can affect Prometheus/OTel time series, dashboards, and alert thresholds even though runtime behavior is otherwise unchanged.
Overview
Introduces shared OpenTelemetry duration histogram bucket helpers in
lib/otel/buckets.go, including a common bucket set and a slower build-specific set.Updates duration histograms across builds/images, HTTP middleware, instances lifecycle/snapshot operations, guest ops, guest memory, volumes, VMM, and egress proxy to use these shared bucket boundaries (removing egress-proxy’s local bucket definitions).
Written by Cursor Bugbot for commit efd6256. This will update automatically on new commits. Configure here.