Skip to content

Add shared histogram buckets for duration metrics#169

Merged
sjmiller609 merged 1 commit into
mainfrom
codex/common-histogram-buckets
Mar 25, 2026
Merged

Add shared histogram buckets for duration metrics#169
sjmiller609 merged 1 commit into
mainfrom
codex/common-histogram-buckets

Conversation

@sjmiller609

@sjmiller609 sjmiller609 commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a shared default duration bucket set for Hypeman duration histograms
  • apply the shared buckets across HTTP, instance lifecycle, guest ops, guest memory, volumes, VMM, and egress proxy histograms
  • use a slower build-specific bucket set for build and image build duration histograms

Testing

  • go test -run '^$' ./lib/middleware ./lib/builds ./lib/otel
  • go test -run '^$' ./lib/images ./lib/guest ./lib/volumes ./lib/vmm ./lib/guestmemory ./lib/egressproxy
  • go test ./lib/instances -run 'TestSnapshotCompressionMetrics_RecordAndObserve|TestInstanceOldestInStateMetric_ObserveOldestAgePerState|TestInstanceTimeToRunningMetric_RecordWhenBootMarkersPersisted|TestLifecycleDurationMetrics_RecordCompressionLabels'

Note

Medium Risk
Changes histogram bucket boundaries for multiple exported duration metrics, which can affect Prometheus/OTel time series, dashboards, and alert thresholds even though runtime behavior is otherwise unchanged.

Overview
Introduces shared OpenTelemetry duration histogram bucket helpers in lib/otel/buckets.go, including a common bucket set and a slower build-specific set.

Updates duration histograms across builds/images, HTTP middleware, instances lifecycle/snapshot operations, guest ops, guest memory, volumes, VMM, and egress proxy to use these shared bucket boundaries (removing egress-proxy’s local bucket definitions).

Written by Cursor Bugbot for commit efd6256. This will update automatically on new commits. Configure here.

@sjmiller609 sjmiller609 marked this pull request as ready for review March 25, 2026 21:51
@sjmiller609 sjmiller609 merged commit 568ae32 into main Mar 25, 2026
6 checks passed
@sjmiller609 sjmiller609 deleted the codex/common-histogram-buckets branch March 25, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant