fix(translator): honor APIKeyPassthrough for Gemini provider#2042
Open
mesutoezdil wants to merge 2 commits into
Open
fix(translator): honor APIKeyPassthrough for Gemini provider#2042mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
github-actions
Bot
added
bug
github-actions
Bot
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Gemini model translation path so it correctly supports APIKeyPassthrough, aligning Gemini with the behavior already implemented for other providers in the ADK agent translator.
Changes:
- Avoid injecting the Google API key env var/secret ref when
APIKeyPassthroughis enabled (and only mount the secret when passthrough is off and a secret is configured). - Ensure the translated
adk.Geminimodel config reflectsapi_key_passthrough.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mesutoezdil
force-pushed
the
fix/gemini-api-key-passthrough
branch
from
a4043fb to
89aa58e
Compare
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
fix/gemini-api-key-passthrough
branch
from
adb6fd6 to
ce7e91f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gemini provider in the model translator was not checking
APIKeyPassthrough.It always tried to mount the Google API key secret, even when passthrough mode was enabled.
It also never set
APIKeyPassthroughon the ADK model struct.All other providers (OpenAI, Anthropic, AzureOpenAI, Ollama) already handle this correctly.