(feat) Add substrate as a subchart#2030
Conversation
Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds optional Helm chart dependencies and configuration knobs to include the “substrate” component (and its CRDs) alongside existing kagent charts.
Changes:
- Introduces
substrate.enabledvalues in bothkagentandkagent-crdsHelm values files (default disabled). - Adds
substrate/substrate-crdsas conditional Helm chart dependencies in the chart templates. - Extends the
helm-versionpackaging flow to stampSUBSTRATE_VERSIONinto generatedChart.yamlfiles.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| helm/kagent/values.yaml | Adds substrate.enabled configuration section (default off). |
| helm/kagent/Chart-template.yaml | Adds conditional substrate dependency using ${SUBSTRATE_VERSION}. |
| helm/kagent-crds/values.yaml | Adds substrate.enabled configuration section (default off) and fixes indentation for kmcp.enabled. |
| helm/kagent-crds/Chart-template.yaml | Adds conditional substrate-crds dependency using ${SUBSTRATE_VERSION}. |
| Makefile | Adds SUBSTRATE_VERSION and injects it into envsubst during Helm chart stamping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
as i see, substrate is already in go.mod (github.com/kagent-dev/substrate v0.0.6), so SUBSTRATE_VERSION can be derived the same way KMCP_VERSION is, instead of being hardcoded? and what is still missing for the WIP label? |
Hey @mesutoezdil Thanks for taking a look! Good catch, I will make substrate subchart version match what's present for KMCP. I initially avoided this because in some cases, it may make sense for the controller to be ahead of the version present in the chart (for example, we're preparing for a release of substrate, so for a certain time the controller supports a version of substrate that's ahead of the version we ship in our chart). If this is every needed, we can revisit. This is WIP since I was distracted with other work, I will be updating the PR description shortly. |
Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
b53c814 to
2093a82
Compare
Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
Description
Adds substrate as a subchart to kagent. Subchart version is based on pinned version in go.mod. Adds an warning in notes.txt warning about regarding experimental support.
Manual Testing