Fix zulip notification on release - #1665
Merged
Merged
Conversation
This pipeline is not triggered on a tag (the tag is created during the pipeline) so github.ref does not exist and the step was skipped. Unfortunately jupyter_releaser's finalize-release does not expose the tag as output and I did not want to add a step to do a sed here.
Yann-P
added
maintenance
github_actions
Collaborator
Author
|
Opened a PR in the releaser to later enrich the Zulip notification with the tag or link to PyPI without having to parse the tag from |
sfc-gh-sbirmiwal
pushed a commit
to sfc-gh-sbirmiwal/jupyter_server
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pipeline is not triggered on a tag (the tag is created during the pipeline) so github.ref does not exist and the step was skipped.
Unfortunately jupyter_releaser's finalize-release does not expose the tag as output and I did not want to add a step to do a sed here.