Recreate notary store on failure to prevent save deadlock and data loss - #1640
Merged
krassowski merged 7 commits intoMay 20, 2026
Merged
Conversation
krassowski
marked this pull request as ready for review
May 12, 2026 15:59
Carreau
approved these changes
May 19, 2026
| # attempt to recreate the database if it detects errors during initialization, | ||
| # and fallback to in-memory (`:memory:`) SQLite database if necessary. | ||
| self.notary.store = self.notary.store_factory() | ||
| self.check_and_sign(nb, path, _retrying=True) |
Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
Collaborator
Author
Contributor
|
Ah! thanks, I suppose a better error is always good anyway. |
Carreau
approved these changes
May 20, 2026
Carreau
left a comment
Carreau
left a comment
Contributor
There was a problem hiding this comment.
+1 to merge and fix the test later if that helps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nbformatsignature store #1639