Fix singular_noun stripping for nouns ending in ics and ess (#214) - #254
Open
Saarthak-Lawand wants to merge 1 commit into
Open
Fix singular_noun stripping for nouns ending in ics and ess (#214)#254Saarthak-Lawand wants to merge 1 commit into
Saarthak-Lawand wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue where the
singular_nounengine aggressively strips trailing 's' characters from mass nouns ending in-ess(like business) and academic/scientific terms ending in-ics(like physics or biomechanics).Changes
ess_nouns) containing invariant singular terms ending in-ess._sinounto catch-icsandess_nounsstrings and returnFalse, correctly preserving their singular status.pytest; all core test cases pass with zero regressions.Closes #214