Fix singular_noun for words ending in -ss - #238
Open
bysiber wants to merge 1 commit into
Open
Conversation
Words like "grass", "glass", "boss", "moss", "cross", "dress" etc. are already singular, but singular_noun() was stripping the final "s" (e.g. "grass" → "gras") because the catch-all rule at the end of _sinoun only checks for a trailing "s". Added a guard for words ending in "ss" before the catch-all, so they correctly return False. Their plural forms (-sses) are unaffected since those are handled by earlier rules. Fixes jaraco#235
|
I'm using this library to normalise plurals in a fork of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
singular_nounreturns wrong results for words ending in-ss:The problem is the catch-all rule at the end of
_sinounthat strips a trailingsfrom any word. Words ending in-ss(like "grass", "glass", "boss", "moss", "cross", "dress") are already singular, so they shouldn't reach this rule.The fix adds a check for
-ssendings right before the catch-all, returningFalsesince these words are already singular. Their plural forms (grasses,glasses, etc.) are still handled correctly by the earlier-ssesrules.All 223 existing tests continue to pass plus 16 new ones covering the fix.
Fixes #235