Avoid TypeError parsing a property name containing '@' - #81
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
The default productions record the wellformed state via new['wellformed'], but _parse's 'new' argument is optional and defaults to None. Parsing a bare property name (which passes new=None) that contains an '@' reached the ATKEYWORD production and raised 'NoneType' object does not support item assignment. Give _parse a throwaway dict when new is None so the input is reported as a normal CSS error instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A property name containing
@makes cssutils raise a bareTypeErrorinstead of a CSS error:The default productions added by
_adddefaultproductionsrecord the wellformed state withnew['wellformed'] = False, but_parse'snewargument is optional and defaults toNone. Parsing a bare property name passesnew=None, so when the name contains@theATKEYWORDproduction dereferencesNone. I defaultnewto a throwaway dict at the top of_parsewhen it isNone, so the malformed name is reported as a normal CSS error (dropped when parsing a whole sheet,SyntaxErrwhen building a declaration directly). Valid CSS is unaffected.Added a test to
TestCSSStyleDeclaration; it raises TypeError onmainand passes with the change, and the declaration suite still passes. Found it by fuzzingparseString.