fix: handle leading '+' sign in to_num string-to-number conversion#12
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
jalvesz
July 13, 2026 06:20
View session
jalvesz
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_num()silently returned0for any numeric string with a leading+(e.g."+1","+1.234"). The integer and all four real parsers (to_sp_base,to_dp_base,to_xdp_base,to_qp_base) only consumed a leading-; a+was left unadvanced, the digit loop found a non-digit immediately, and the parser succeeded with value0.Changes
src/strings/stdlib_str2num.fypp— in all fiveto_*_baseparsers, extended the leading-sign check from anif(minus only) toif / else ifthat also consumes a leading+and advancesp. Updated the comment from "Verify leading negative" to "Verify leading sign".test/string/test_string_to_number.fypp— added regression cases for integers ("+1","+42"," +99","+0005") and reals ("+1","+1.234") across all type variants.