Skip to content

Do not overwrite existing NanoLimbo settings.yml - #3799

Merged
itzg merged 2 commits into
itzg:masterfrom
akippnn:master
Dec 13, 2025
Merged

Do not overwrite existing NanoLimbo settings.yml#3799
itzg merged 2 commits into
itzg:masterfrom
akippnn:master

Conversation

@akippnn

@akippnn akippnn commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Ran into a likely edge case where any modified changes to the settings.yml is immediately overwritten by the start-deployNanoLimbo bash script every time the container starts. This change fixed it for me.

@itzg

itzg commented Dec 11, 2025

Copy link
Copy Markdown
Owner

The file is being rewritten every time on purpose in order to ensure container variables are applied, such as SERVER_PORT.

Can you describe your edge case?

@akippnn

akippnn commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

The file is being rewritten every time on purpose in order to ensure container variables are applied, such as SERVER_PORT.

Can you describe your edge case?

I modified NanoLimbo's configuration using the /config bind mount with COPY_CONFIG_DEST=/data to add environment variable substitutions (e.g. infoForwarding.secret=${CFG_VELOCITY_SECRET}), but this setup would not work because start-setupMounts intentionally skips newer files in destination.

The other workaround seems to be making patch definitions. I am mostly abusing /config for continuity (since the servers were architected this way since 1.19).

Since SERVER_PORT is the only variable modified, is using mc-image-helper patch to place ${SERVER_PORT} in bind.port good in this case? This would still replace any manual edits for the bind.port but it would be more usable than replacing the entire file altogether.

@itzg

itzg commented Dec 12, 2025

Copy link
Copy Markdown
Owner

Since SERVER_PORT is the only variable modified, is using mc-image-helper patch to place ${SERVER_PORT} in bind.port good in this case?

Yeah, that seems like a good solution.

@akippnn
akippnn force-pushed the master branch 2 times, most recently from 88ee76a to 64aea5e Compare December 12, 2025 03:07
Comment thread scripts/start-deployNanoLimbo Outdated
@itzg itzg changed the title Do not overwrite existing settings.yml in scripts/start-deployNanoLimbo Do not overwrite existing NanoLimbo settings.yml Dec 12, 2025
@itzg
itzg merged commit d7d3cc5 into itzg:master Dec 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants