#323: PID + Source URL columns in samples table and CSV export#328
Merged
Conversation
…port Andrea's ask (isamplesorg#323): 1. PID column in the samples table (was CSV-only) — placed after Label, ellipsized via CSS (pids like ark:/28722/… are long) with the full pid on hover and always complete in the CSV. 2. Source URL column — a dedicated external link (n2t.net resolver via the existing unit-tested sourceUrl() helper) to the sample's landing page at its source repository, in both the table and the CSV (appended as the LAST csv column so isamplesorg#312-era consumers keep their column positions). Does not reopen isamplesorg#226 (which removed the label cell's href): the external link lives in its own honestly-labeled cell, and activateRow now ignores clicks originating inside an <a> so a link click opens the record without also selecting/flying the row. Refs isamplesorg#323. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjnkWb4HpuLeDbYfzmY3X9
…eview) Screen-reader users tabbing down the column otherwise hear an undifferentiated list of identical "record ↗" links. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjnkWb4HpuLeDbYfzmY3X9
Contributor
Author
|
Codex 5.6 verdict (independent review): "approve after one focused browser smoke test… reuses the existing tested sourceUrl(); attribute values are escaped; CSV ordering remains backward-compatible; anchor clicks no longer trigger row selection; rel=noopener noreferrer is correct. I found no code blocker." The requested smoke test was performed (see PR body: link-vs-row click, keyboard focus, narrow viewport, fresh context) and its aria-label suggestion applied in 9ed195c. — rbotyee 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Implements @akthom's #323:
ark:/28722/…pids are long) with the full pid on hover, and always complete in the CSV.n2t.netresolver via the existing unit-testedsourceUrl()helper) to each sample's landing page at its source repository, in both the table and the CSV. In the CSV it's appended as the last column so Make it possible to download CSV of Samples Table #312-era consumers keep their column positions.Design notes:
activateRownow ignores clicks originating inside an<a>, so a link click opens the record without also selecting/flying the row.aria-labelon each link (Codex review) so screen readers announce which record each identical "record ↗" link opens.Codex review (5.6)
Smoke test performed (fork preview, fresh isolated browser context)
…|PID|…|Source URL; pid cell ellipsizes with full pid intitle; linkhref=https://n2t.net/<pid>,target=_blank,rel=noopener noreferrer✅.table-scroll, body does not overflow (fresh load; matches prod behavior) ✅Closes #323.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AjnkWb4HpuLeDbYfzmY3X9