Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Add document for running JS IPFS in the browser - #2392

Merged
alanshaw merged 21 commits into
ipfs:masterfrom
tapaswenipathak:ticket-2231
Dec 6, 2019
Merged

Add document for running JS IPFS in the browser#2392
alanshaw merged 21 commits into
ipfs:masterfrom
tapaswenipathak:ticket-2231

Conversation

@tapaswenipathak

@tapaswenipathak tapaswenipathak commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Fixes #2231.

@alanshaw

Copy link
Copy Markdown
Member

Thanks @tapaswenipathak I'll get round to reviewing this asap!

@daviddias daviddias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapaswenipathak this is a very cool draft! It does pack a few things that are incoherent. I left a few comments :)

Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
@tapaswenipathak

Copy link
Copy Markdown
Contributor Author

@daviddias: you can review now.

Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
tapaswenipathak and others added 2 commits October 16, 2019 05:27
Co-Authored-By: David Dias <daviddias.p@gmail.com>
Co-Authored-By: David Dias <daviddias.p@gmail.com>

@lidel lidel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tapaswenipathak! I suggested some changes to make it more aligned with how things look like on the technical side:

Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
Comment thread doc/using-js-ipfs-in-the-browser.md Outdated
@tapaswenipathak

tapaswenipathak commented Oct 16, 2019

Copy link
Copy Markdown
Contributor Author

@lidel: Very creative statements/writeups; you can review now.

@lidel lidel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tapaswenipathak!

I changed the order of the document a bit, and added references to external resources with more info to make this reusable on our docs portal as well (at some point we will move this content to https://docs.ipfs.io/reference/js/overview/, but for now let's keep it here)


LGTM, but I would like someone else to proof-read it before we merge.

@lidel
lidel requested a review from daviddias October 18, 2019 12:00
@lidel
lidel requested a review from alanshaw October 18, 2019 12:00
@autonome

autonome commented Dec 6, 2019

Copy link
Copy Markdown
Contributor

This is a great document! It answers many questions in a concise way.

Any reason to not merge this as it is, and continue to iterate from there?

@alanshaw
alanshaw merged commit 79db03b into ipfs:master Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the state of IPFS in the browser

6 participants