fix: use vars.NEXT_PUBLIC_SENTRY_DSN in CF Pages deploy workflows#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-cf-pages-prod.yml:secrets.NEXT_PUBLIC_SENTRY_DSN→vars.NEXT_PUBLIC_SENTRY_DSNdeploy-cf-pages-staging.yml: 补充缺失的NEXT_PUBLIC_SENTRY_DSN，同样用vars.*Root Cause
DSN 存在 GitHub Variables 而非 Secrets，workflow 引用方式不对导致构建时 DSN 为空，Sentry 不初始化，线上看不到 Feedback 按钮。
Test plan
staging.safe.iotex.io右下角出现 Sentry Feedback 按钮iotex分支后验证safe.iotex.io