feat(tabs): migrate to Modular Ionic #31116
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. Was adding the
Contributor
Author
There was a problem hiding this comment. Yes, we've been doing that with all the components we've migrated. Should we be using singular? If so, I can make those changes in a different PR. |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| import { newSpecPage } from '@stencil/core/testing'; | ||
|
|
||
| import { Tab } from '../../tab/tab'; | ||
| import { Tabs } from '../tabs'; | ||
|
|
||
| const HTML = ` | ||
| <ion-tabs> | ||
| <ion-tab tab="tab-one"></ion-tab> | ||
| <ion-tab tab="tab-two"></ion-tab> | ||
| </ion-tabs> | ||
| `; | ||
|
|
||
| describe('ion-tabs', () => { | ||
| describe('getSelected()', () => { | ||
| it('should return the name of the initially selected tab', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
| expect(await tabsEl.getSelected()).toBe('tab-one'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getTab()', () => { | ||
| let consoleErrorSpy: jest.SpyInstance; | ||
|
|
||
| beforeEach(() => { | ||
| // getTab() calls printIonError when the tab id is not found, suppress to keep test output clean | ||
| consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| consoleErrorSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('should return the element for an existing tab id', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
| const tabEl = page.body.querySelector('ion-tab[tab="tab-two"]')!; | ||
| expect(await tabsEl.getTab('tab-two')).toBe(tabEl); | ||
| }); | ||
|
|
||
| it('should return undefined for a non-existent tab id', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
| expect(await tabsEl.getTab('does-not-exist')).toBeUndefined(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('select()', () => { | ||
| let consoleErrorSpy: jest.SpyInstance; | ||
|
|
||
| beforeEach(() => { | ||
| // select() calls printIonError when the tab id is not found, suppress to keep test output clean | ||
| consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| consoleErrorSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('should switch to the specified tab and return true', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
| const result = await tabsEl.select('tab-two'); | ||
|
|
||
| expect(result).toBe(true); | ||
| expect(await tabsEl.getSelected()).toBe('tab-two'); | ||
| }); | ||
|
|
||
| it('should return false when selecting the already active tab', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
| const result = await tabsEl.select('tab-one'); | ||
|
|
||
| expect(result).toBe(false); | ||
| }); | ||
|
|
||
| it('should return false when selecting a non-existent tab id', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
| const result = await tabsEl.select('does-not-exist'); | ||
|
|
||
| expect(result).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('events', () => { | ||
| it('should emit ionTabsWillChange and ionTabsDidChange when switching tabs', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
|
|
||
| const willChangeSpy = jest.fn(); | ||
| const didChangeSpy = jest.fn(); | ||
| tabsEl.addEventListener('ionTabsWillChange', willChangeSpy); | ||
| tabsEl.addEventListener('ionTabsDidChange', didChangeSpy); | ||
|
|
||
| await tabsEl.select('tab-two'); | ||
| await page.waitForChanges(); | ||
|
|
||
| expect(willChangeSpy).toHaveBeenCalledWith(expect.objectContaining({ detail: { tab: 'tab-two' } })); | ||
| expect(didChangeSpy).toHaveBeenCalledWith(expect.objectContaining({ detail: { tab: 'tab-two' } })); | ||
| }); | ||
|
|
||
| it('should not emit ionTabsDidChange when selecting the already active tab', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
|
|
||
| const didChangeSpy = jest.fn(); | ||
| tabsEl.addEventListener('ionTabsDidChange', didChangeSpy); | ||
|
|
||
| await tabsEl.select('tab-one'); | ||
|
|
||
| expect(didChangeSpy).not.toHaveBeenCalled(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('error handling', () => { | ||
| let consoleErrorSpy: jest.SpyInstance; | ||
|
|
||
| beforeEach(() => { | ||
| // select() calls printIonError when the tab id is not found, suppress to keep test output clean | ||
| consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| consoleErrorSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('should log the correct tab id when selecting a non-existent tab', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [Tabs, Tab], | ||
| html: HTML, | ||
| }); | ||
|
|
||
| const tabsEl = page.body.querySelector('ion-tabs')!; | ||
| await tabsEl.select('does-not-exist'); | ||
|
|
||
| expect(consoleErrorSpy).toHaveBeenCalledWith( | ||
| '[Ionic Error]: [ion-tabs] - Tab with id: "does-not-exist" does not exist' | ||
| ); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this not changed to
@use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to minimize the changes in other components as much as possible. The
usemigration will be done when we migratenavto ionic modular. This is just a precaution in case an issue occurs. I don't want to spend more time on components that are not in the scope of tickets.