feat(anima): bundle T5-XXL tokenizer, remove t5_encoder_model input#9244
Open
kappacommit wants to merge 2 commits into
Open
feat(anima): bundle T5-XXL tokenizer, remove t5_encoder_model input#9244kappacommit wants to merge 2 commits into
kappacommit wants to merge 2 commits into
Conversation
Anima only needs the T5-XXL tokenizer (token IDs for the LLM Adapter embedding), not the ~9GB encoder weights. Vendor the self-contained tokenizer.json inside the package and load it from a bundled path, so users no longer have to download the full T5 encoder model. Removes the t5_encoder_model input from the Anima model loader and strips all corresponding frontend state, selectors, metadata handlers, readiness checks, graph edges, i18n keys, and starter-model deps. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
kappacommit
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
github-actions
Bot
added
python
…ma path slashes The committed openapi.json was stale (still 1.3.0 with t5_encoder_model); regenerate the Anima loader/text-encoder sections to match the 1.4.0 source. Also correct two Windows backslash cache-path defaults in schema.ts to the forward slashes the Linux typegen produces, so the openapi/typegen CI checks pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anima only needs the T5-XXL tokenizer (token IDs for the LLM Adapter embedding), not the ~9GB encoder weights. This PR stores the tokenizer itself in the repo and loads it locally. The tokenizer is Apache 2.0 license, so it is license compatible to store, and this is how both Comfy and Forge handle this as well (they both just store the tokenizer in the repo.)
Removes the t5_encoder_model input from the Anima model loader and strips all corresponding frontend state, selectors, metadata handlers, readiness checks, graph edges, i18n keys, and starter-model deps.
This saves about 9gb of space, and resolve much user confusion when they think the t5 encoder is being loaded into VRAM (it never was, but they were confused about it.)
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)