Remove duplicated TensorCompare kernels - #3535
Merged
Merged
Conversation
Silv3S
added
disable_e2e
Contributor
There was a problem hiding this comment.
Pull request overview
Read skill file(s): .github/skills/xpu-ops-pr-review/SKILL.md.
This PR removes a dead/duplicated SYCL implementation file for TensorCompare-related kernels (where/clamp), reducing duplicate code paths in the XPU backend.
Changes:
- Delete
src/ATen/native/xpu/sycl/TensorCompare.cpp, whoseWhereFunctor/Clamp*code is already present inTensorCompareKernels.cpp. - Rely on the existing
TensorCompareKernels.cppimplementations forwhere/clamp/clamp_scalarkernels (no functional change expected).
BBBela
approved these changes
Apr 30, 2026
BBBela
left a comment
BBBela
left a comment
Contributor
There was a problem hiding this comment.
Always good to remove some dead and unused code.
Thanks for those changes!
Contributor
Author
|
/merge |
Contributor
|
✅ PR has been successfully merged by @Silv3S. |
Copilot AI
pushed a commit
that referenced
this pull request
May 12, 2026
During #3425 analysis I found duplicated where/clip kernels. It seems to be dead code, worth removal Co-authored-by: liangan1 <46986936+liangan1@users.noreply.github.com>
zxd1997066
pushed a commit
that referenced
this pull request
May 15, 2026
During #3425 analysis I found duplicated where/clip kernels. It seems to be dead code, worth removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During #3425 analysis I found duplicated where/clip kernels. It seems to be dead code, worth removal