Won't trycatch different types - #15
Merged
Merged
Conversation
Contributor
Author
|
The failed build looks unrelated to the pull. |
This comment has been minimized.
This comment has been minimized.
ljharb
added
the
needs "allow edits"
This comment has been minimized.
This comment has been minimized.
ljharb
removed
the
needs "allow edits"
Member
|
hmm - how does this affect comparing a function to an object? that's the one case I'd be worried about. |
Member
|
nvm, looked at https://github.com/nodejs/node/blob/master/lib/internal/util/comparisons.js and added some tests to this PR. |
ljharb
approved these changes
Aug 3, 2019
ljharb
added a commit
that referenced
this pull request
Aug 28, 2019
This technically could have been a patch, but I'm making it a minor out of an abundance of caution. - [Fix] use `is-date-object` to properly detect cross-realm Dates - [Fix] ensure Buffer + non-Buffer comparison order does not matter - [Fix] properly compare RegExp objects - [Fix] use `object-is` to support `NaN` and `-0` properly (#57, #20) - [Fix] (array,arguments) now behaves the same as (arguments,array) (#56) - [Refactor] there is no need to do further comparing when two types are not equal (#44) - [Refactor] `objEquiv`: bail early if typeofs are different (#15) - [Refactor] Use `object-keys` and `is-arguments` instead of a homegrown shim (#4) - [Refactor] move Date and RegExp tests into `objEquiv` - [Dev Deps] update `tape` - [Tests] make a `tape` helper, to easily compare loose/strict, and (a,b)/(b,a) arg order - [Tests] add array/object tests; clean up/flesh out tests - [Tests] add tests for `Object.create(null)` (#50) - [Tests] Fails simple array tests on IE < 9 #10 (#64) - [Tests] add `npm run lint` - [Tests] up to `node` `v12.7`, `v11.15`, `v10.16`, `v9.11`, `v8.16`, `v7.10`, `v6.17`, `4.9`; use `nvm install-latest-npm` - [meta] fix license text so GitHub can detect it - [meta] Add copyright statements (#59, #14) - [meta] Only apps should have lockfiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version will hit the trycatch in objEquiv if you compare, for example,
falseto[]This should significantly improve the performance of checks between values of different types.
Tests pass, however I'm not totally confident that there are enough tests to catch potential edge cases.