remove global env variables and replaces them by step-based env variables

[Chrico]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes/features)
• Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Following changes have been done do several workflows:

NODE_AUTH_TOKEN

The secrets.NODE_AUTH_TOKEN was removed from global "env" and added to "Setup up node"-step as local "env"-variable

GITHUB_USER_SSH_KEY

Removed from global "env" and

1. moved to actions/checkout@v4 and with.ssh-key directly.
2. moved as local "env" variables to "Set up SSH"-step.

GITHUB_USER_SSH_PUBLIC_KEY

The public SSH Key was removed from global "env" and injected into "Delete signing key files"- and "Set up signin commits"-steps as local "env" variable.

GITHUB_USER_EMAIL and GITHUB_USER_NAME

Remove both secrets from global "env" and moved them into "Set up Git"-step as local "env" variables.

NODE_OPTIONS

are moved out of the global "env" into the specific step where it is needed.

COMPOSER_AUTH

are moved out of the global "env" into the specific step where it is needed for installing composer dependencies.

[Chrico]

We might want to discuss if this is correct:

- name: Set up Git
    env:
      GITHUB_USER_EMAIL: ${{ secrets.GITHUB_USER_EMAIL }}
      GITHUB_USER_NAME: ${{ secrets.GITHUB_USER_NAME }}
    if: ${{ env.GITHUB_USER_EMAIL != '' && env.GITHUB_USER_NAME != '' }}
    run: |
      git config --global user.email "${{ env.GITHUB_USER_EMAIL }}"
      git config --global user.name "${{ env.GITHUB_USER_NAME }}"

both, the secrets.GITHUB_USER_EMAIL and secrets.GITHUB_USER_NAME are optional, but in theory you could also just set 1 of both. But this if:-statement requires both to be set at the same time. Is there any use case where we just want to have 1 set or are both always required to ensure that it works?

As alternative we could use something like:

- name: Set up Git
    run: |
      ${{ secrets.GITHUB_USER_EMAIL != '' }} && git config --global user.email "${{ secrets.GITHUB_USER_EMAIL }}"
      ${{ secrets.GITHUB_USER_NAME != '' }} && git config --global user.name "${{ secrets.GITHUB_USER_NAME }}"

and/or we could also print a message (or document down), that if you decide to "Set up Git" you need both in order to function.

[tyrann0us]

Thank you for working on this. I left a couple of comments.

Is there any use case where we just want to have 1 set or are both always required to ensure that it works?

I would keep this as-is.

[tyrann0us]

Thank you for incorporating the changes. I left a question and a request; this should be good to go once these are resolved. 😉

[dottxado]

I only have a minor comment: please update the PR description to include the NODE_OPTIONS moving 😄

[Chrico]

I only have a minor comment: please update the PR description to include the NODE_OPTIONS moving 😄

done 😬 and also added COMPOSER_AUTH ;-)

[tyrann0us]

I'm still unsure how many times we have to declare the local COMPOSER_AUTH variable, but this doesn't prevent me from approving. Thank you for working on this! 💪🏽 LGTM.