Enable users to import with import/require#1
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 16 16
Branches 6 6
=========================================
Hits 16 16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The users right now can't use
"commonjs"/requirewith your package because you're usingtype="module"witch obligates all the users that download your package to use"module/import"witch is a issue, because in legacy projects you might need still use"commonjs"/requireWhat I changed
type="module"from yourpackage.json(with this change the users can useimport/require syntaxwith your package).jsand jest.config.jsfiles to rollup.config.mjs, jest.config.mjs(with this change you can still useimport syntaxinside those files)Testing
Setup
npm init/distwith the commandyarn buildand copy/distfolder inside anode_modules/@includedaniel/fibonaccifolderTesting with
commonjs/require syntaxNode index.jsyou should get75025Testing with
module/import syntaxtype="module"at this node app package.json)Node index.mjsyou should get75025