Repository navigation
fix(cli): stop using 'failed' for two different things in run summary - #5
Closed
n-papaioannou wants to merge 1 commit into
Closed
n-papaioannou wants to merge 1 commit into
n-papaioannou wants to merge 1 commit into
Conversation
… things
The post-run summary line said "{n} out of {total} tests have failed",
but {n} counted only tests with insufficient_evidence. The per-category
bars on the same screen marked tests as failed when they didn't pass
their score threshold. Same word, two definitions, two visibly
contradictory counts (e.g. bars: 8 ✗, line: 6 / 8 failed).
Reword to make the distinction explicit:
- success branch: "All {N} tests produced sufficient evidence to be scored."
- failure branch: "{n} out of {total} tests had insufficient evidence to
be scored ({ids}). The remaining tests were scored but may still be
below threshold -- see the per-category bars above."
n-papaioannou
requested review from
Sebabaian,
dimneo and
stefyi-4355
as code owners
April 28, 2026 14:06
stefyi-4355
approved these changes
Apr 28, 2026
Contributor
Author
|
Superseded by #6 — the run-summary wording fix from this PR is already included in the dev→public sync (came in as dev commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bars and summary line both used "failed" for different things (below-threshold vs insufficient-evidence), producing contradictory counts. Reworded the summary line to say "insufficient evidence" explicitly.