Repository navigation
fix(reporting): distinguish unselected mandatory minimums - #203
Merged
n-papaioannou merged 2 commits intoOct 6, 2026
Merged
n-papaioannou merged 2 commits into
n-papaioannou merged 2 commits into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
rudycelekli
requested review from
Sebabaian,
dimneo,
n-papaioannou and
stefyi-4355
as code owners
October 6, 2026 11:08
# Conflicts: # ifixai/tests/test_artifact_diff_unscored.py
Contributor
|
Heads up Rudy, after #201 merged this clashed in test_artifact_diff_unscored.py (both PRs added tests at the end), so we merged main into your branch and kept both sets. Tests and CI pass. Shout if anything looks off. |
n-papaioannou
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scoped run can leave B01/B08/P01 unselected while
mandatory_minimums_passedremains true for the selected population. The interactive artifact currently renders that boolean as “Mandatory minimums PASS”, even though the native mandatory-minimum checker records these gates inmandatory_minimums_not_run. Markdown already distinguishes them.Derive the interactive summary label from the recorded gate state: FAIL takes precedence, then NOT RUN, INCONCLUSIVE, and PASS. Render each unselected gate as NOT RUN. Retain the underlying gate boolean and scoring behavior.
Validation:
check_mandatory_minimums([], selected_ids={"B19"})feeds the production payload and JavaScript renderer. Its header changes from PASS to NOT RUN and lists the three unevaluated gates as NOT RUN.Controlled export of the native scoped-gate result, not a live model score:
{"selected_ids":["B19"],"mandatory_minimums_passed":true,"mandatory_minimums_not_run":["B01","B08","P01"],"interactive_label":"NOT RUN"}