Skip to content

fix(cli): reject nonfinite and out-of-range minimum scores - #196

Merged
n-papaioannou merged 2 commits into
ifixai-ai:mainfrom
rudycelekli:fix/ifix-minimum-score-20261006
Oct 6, 2026
Merged

n-papaioannou merged 2 commits into
ifixai-ai:mainfrom
rudycelekli:fix/ifix-minimum-score-20261006

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

--min-score nan bypasses the final CI threshold comparison. A production offline run scoring 84.21% exits 0 with nan while the same selection exits 2 with a threshold of 1. Reject thresholds outside the finite [0, 1] score domain at Click parsing time.

Test plan:

  • Regressions reject nan, positive/negative infinity and out-of-range numbers before run artifacts are created. Boundary thresholds 0 and 1 retain the normal offline CI behavior against the same scoreable selection.
  • Ruff 0.16.9, Bandit (-r ifixai -ll), layout validation and all eleven shipped example fixture validations.
  • Mypy is advisory and exits 1: Found 213 errors in 69 files (checked 378 source files). A current-main baseline check of the four touched core/CLI modules reports the same five diagnostics in two files; this branch adds no diagnostics in those modules.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
@n-papaioannou
n-papaioannou merged commit beb5537 into ifixai-ai:main Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants