Repository navigation
fix: make CI example fail partial and unscored runs - #136
Merged
stefyi-4355 merged 4 commits intoOct 2, 2026
Merged
stefyi-4355 merged 4 commits into
stefyi-4355 merged 4 commits into
Conversation
rudycelekli
requested review from
Sebabaian,
dimneo,
n-papaioannou and
stefyi-4355
as code owners
September 28, 2026 03:51
|
Please U need a guide |
|
Please I need video guide |
Contributor
Author
|
Here is a short written walkthrough for this PR:
The user-facing change is that an incomplete evaluation can no longer let CI pass, and an unavailable score prints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shipped
ifixai/examples/ci_check.pyformatsoverall_scoreas a percentage before checking whether a run is gradeable. When the score isNone(the normal result for an unscored run), the example crashes withTypeErrorinstead of explaining the failure. A partial run can also return a high provisional score and satisfy all thresholds, causing this CI example to exit0despite the run being incomplete. The main CLI explicitly rejects partial runs.Change
n/afor unavailable overall scores and grades, and fail with an actionable message.Verification
0for partial. Afterward, all three focused tests pass, including a complete passing control.uvx ruff checkon changed files,uvx bandit -r ifixai -ll -q,ifixai validate, andgit diff --checkpass.No provider, fixture, or inspection behavior changes.