🖍️ Color n' Constant Changes (#739) - #741
Merged
Merged
Conversation
This was
linked to
issues
May 14, 2026
Closed
TheAbubakrAbu
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the systematic elimination of all remaining hardcoded hex color values ("magic constants") across the Next.js frontend, centralizing them as semantically named CSS variables in
globals.cssfor robust dark/light mode consistency. It also integrates key UI state refactors, optimization/performance fixes for dishes rendering, and addresses merge conflict cleanups.Changes
🎨 Color & Theme Centralization (Magic Constants Clean-up)
globals.css): Expanded variables for surfaces (--surface-modal,--surface-dialog,--surface-tinted,--surface-scroll,--surface-elevated), borders (--border-input,--accent-border), text colors, calendars, and tabs.var(...)references inside:food-dialog-content.tsx,food-drawer-content.tsx,event-dialog-content.tsx,event-drawer-content.tsx,ingredients-dialog.tsx.calendar-view.tsx,my-foods/page.tsx,events/page.tsx,edit-preferences-content.tsx.restaurant-filters.tsx,mobile-actions.tsx,desktop-tabs.tsx.#8EC5FF33consistently acrossnutrition-goals.tsx,nutrition-breakdown.tsx,mobile-nutrition-bars.tsx,meal-search.tsx, andmobile-calorie-card.tsx.⚡ Performance & State Management Refactoring (Restaurant UI)
useMemoindishes-view.tsx. This avoids redundantgetDietaryConflictscomputations on every render when switching views (e.g. togglingisCompactViewor stations).isCompactView,showPreferencesOnly,selectedStation) touseRestaurantUIStoreor resolved them in a centraluseRestaurantPagecustom hook.restaurant-controls.tsxandrestaurant-page.tsxby reducing drilldown props and offloading lifecycle operations to hooks/stores.Closes #739, #727, #734, #728