feat(traces): break-word attribute wrapping + layout toggle#2693
feat(traces): break-word attribute wrapping + layout toggle#2693karl-power wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 1446fb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
E2E Test Results✅ All tests passed • 242 passed • 1 skipped • 876s
Tests ran across 4 shards in parallel. |
Deep Review
🔴 P0/P1 -- must fix
🔵 P3 nitpicks (2)
Reviewers (4): correctness, maintainability, frontend-races, testing (analysis performed by reading the PR head; diff-based fan-out unavailable in this environment). Testing gaps:
|
|
@karl-power deferring to you for the nitpicks in this PR or a follow on. Thanks! |
Greptile SummaryThis PR updates the trace span detail UI. The main changes are:
Confidence Score: 4/5This is close, but the trace layout should be fixed before merging.
packages/app/src/components/DBTracePanel.tsx Important Files Changed
Reviews (4): Last reviewed commit: "fix(traces): align span detail content w..." | Re-trigger Greptile |
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
…e keys Address review nits from @elizabetdev: - Add a `flush` prop to RowOverviewPanel/RowDataPanel that zeroes their inline padding, set only from the trace SpanDetailPanel so the detail content aligns with the tab bar. The row drawer and inline expanded row are unchanged. - Cap the HyperJson key column at 50% of the row and wrap unbroken keys (overflow-wrap: anywhere) so long keys like longtask.attribution.entry_type can't squeeze the value column to one character per line.
ffdcd2e to
1446fb0
Compare


Summary
Addresses user feedback from #2689 about the redesigned trace UI.
What changed
Review follow-ups (from @elizabetdev):
longtask.attribution.entry_type) now wrap and are capped at half the row width so they can't squeeze the value column down to one character per line.Screenshots or video
Screen.Recording.2026-07-21.at.13.11.09.mov
How to test on Vercel preview
Preview routes:
/searchSteps:
trace-detail-layout-toggle) next to the close button and verify the detail panel moves to the bottom of the waterfall, then toggle it back.References