karma/hyper 142 quickstart page#79
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReplaces AtpAgent-based server login with NodeOAuthClient authorize()/callback() browser OAuth flow, updates imports and session usage, and refactors the hypercert creation example to use an explicit workScope object with $type. Adds a "Create a hypercert without code" guide section. Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant AppServer as NodeOAuthClient
participant PDS
participant Session as SessionObject
participant Repo as ATProtoRepo
Browser->>AppServer: GET /authorize (user clicks "Connect")
AppServer->>PDS: authorize(...) -> returns authorization URL
AppServer-->>Browser: 302 redirect to PDS auth URL
Browser->>PDS: User authenticates & approves
PDS-->>Browser: Redirect back with callback params
Browser->>AppServer: GET /callback?code=...
AppServer->>PDS: callback(params) -> exchange code for session
PDS-->>AppServer: session (includes session.did and session.agent)
AppServer->>Repo: session.agent.com.atproto.repo.createRecord(repo: session.did, record: {...workScope...})
Repo-->>AppServer: creation result
AppServer-->>Browser: Show result / console.log(result)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pages/getting-started/quickstart.md`:
- Around line 164-169: Update the table entries to correct terminology and
capitalization: change "DIDS" to "DIDs" in the "Evaluators" row, and replace the
"Measurement" row's fragment "URI to the measurement that is tied to this
evaluation. Could be a normal url as well" with a full sentence such as "URI to
the measurement tied to this evaluation. It can also be a normal URL." Ensure
"URL" is capitalized.
- Line 43: Update the sentence in pages/getting-started/quickstart.md: replace
"checkout" with "check out" and "setup OAuth" with "set up OAuth" so the
sentence reads more cleanly (the sentence that starts "See the [AT Protocol
OAuth documentation]..."; also ensure link text like "[AT Protos node.js
implementation tutorial]" remains unchanged aside from the two wording fixes).
- Around line 20-22: The Markdoc callout uses an unsupported type value: change
the callout tag's type attribute from "note" to a supported value (for example
"info") in the callout surrounding the React app note (the {% callout
type="note" %} ... {% /callout %} block) so the page will render correctly;
update the type attribute and ensure the opening and closing {% callout %} tags
remain balanced.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 13940360-1940-4c74-9203-7702e226b5a8
📒 Files selected for processing (1)
pages/getting-started/quickstart.md
b4a0959 to
8a63a79
Compare
Summary by CodeRabbit