feat(desktop): flag secret env vars in the {{ref}} highlight#98
Merged
Conversation
gandarfh
force-pushed
the
feat/secret-ref-highlight
branch
3 times, most recently
from
f558b17 to
f6efa82
Compare
gandarfh
force-pushed
the
feat/secret-ref-highlight
branch
from
f6efa82 to
a7f9592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop visual half of the secret env-var signalling (server half is the
secrettoken modifier in httui-lang). A bare{{KEY}}whose head matches a keychain-backed (is_secret) variable in the active environment is painted with.cm-ref-secret(amber + dotted underline), distinct from the purple ref highlight. Dotted/path refs ({{KEY.body}}) are block references, never marked.Source: a module-level set (
secret-env-keys.ts) the environment store repopulates on refresh from the active env variables — the highlight reads it synchronously, same pattern as the editor content/unsaved sets. The desktop does not consume server semantic tokens (Lezer first-paint), so is_secret comes from the store, not the server.7 tests green (3 new). Known minor: on an env switch the highlight refreshes on the next edit/scroll (module-level set, no forced redecorate). Pending owner visual gate.